refactor(journey): snooze-conversation-node orphan case (EVO-1920)#95
Merged
dpaes merged 1 commit intoJun 25, 2026
Conversation
O case 'snooze-conversation-node' era inalcancavel: nenhum no do editor de jornadas no FE, trigger ou fixture de jornada salva emite esse type. O case 'defer-conversation-node' (unico type canonico do FE) ja invoca o mesmo executor (executeSnoozeConversationNode), entao a funcionalidade de snooze e preservada. Comentario atualizado documentando a consolidacao.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @daniloleonecarneiro, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
dpaes
approved these changes
Jun 25, 2026
dpaes
left a comment
dpaes
left a comment
There was a problem hiding this comment.
Approved — deep adversarial review (card + authoritative diff + real code): acceptance criteria met, no blocking findings. Merge intentionally held to land in the coordinated dependency-order pass. Branch is clean vs develop.
dpaes
deleted the
danilocarneiro/evo-1920-jornadas-registry-case-snooze-conversation-node-orfao-fe-so
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove o case órfão
snooze-conversation-nodedojourney-execution.workflow.ts.Escolha + justificativa
O workflow tinha dois cases (
snooze-conversation-nodeedefer-conversation-node) apontando para o mesmo executorexecuteSnoozeConversationNode. Confirmei que:defer-conversation-node(pastaactions/defer-conversation); não existe nósnooze-conversation-nodeno palette/manifest da jornada.snooze-conversation-nodeno FE estão no subsistema de Automação (automationService.ts, color map emlib/utils.ts) — domínio separado, que não emite eventos de workflow de jornada para o evo-flow.snooze-conversation-nodeaparecia só no case do workflow — nenhum trigger, fixture JSON, jornada salva ou teste depende dele.journey-execution.coverage.spec.ts) valida 1 case por nó do palette e temdefer-conversation-node; não havia teste parasnooze-conversation-node(nunca foi nó do palette).Logo o case era inalcançável e redundante. Removi-o e mantive
defer-conversation-node(o type canônico do FE), que já invoca o mesmo executor — sem perda de funcionalidade. O efeito CRM continua sendo "snoozed", por isso o executor preserva o nomeexecuteSnoozeConversationNode. Comentário atualizado documentando a consolidação.Critério de aceite
Um único tipo de nó (
defer-conversation-node) consistente entre FE e backend. ✓Test plan
tsc -p tsconfig.json --noEmit→ OK (exit 0)jest journey-execution.coverage.spec.ts→ 26/26 passando (inclui assert do casedefer-conversation-node)EVO-1920